Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add algo aurora #144

Merged
merged 30 commits into from
Dec 11, 2023
Merged

Feat: add algo aurora #144

merged 30 commits into from
Dec 11, 2023

Conversation

felixchalumeau
Copy link
Collaborator

@felixchalumeau felixchalumeau commented Mar 1, 2023

Related issues: #142

This PR introduces AURORA and PGA-AURORA, algorithms that define the behaviour descriptor in an unsupervised manner.

This PR introduces:

  • unstructured repertoire
  • aurora class
  • utils to define an auto encoder with lstm
  • test for aurora
  • example for aurora and pga aurora
  • updated readme and docs

Checks

  • a clear description of the PR has been added
  • sufficient tests have been written
  • relevant section added to the documentation
  • example notebook added to the repo
  • clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

We are pushing this PR to have the code open sourced for ICLR but some part of the code do not reach the code quality standard that we have been fixing for QDax until now. I will open an issue: we will need to clean this in the near future.

@felixchalumeau felixchalumeau marked this pull request as draft March 1, 2023 16:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.87305% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (b221c68) to head (6c5801e).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
qdax/core/containers/unstructured_repertoire.py 83.47% 19 Missing ⚠️
tests/core_test/aurora_test.py 90.32% 9 Missing ⚠️
qdax/utils/train_seq2seq.py 95.58% 3 Missing ⚠️
...x/core/neuroevolution/networks/seq2seq_networks.py 98.59% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
+ Coverage    92.28%   92.30%   +0.01%     
===========================================
  Files          120      125       +5     
  Lines         7055     7485     +430     
===========================================
+ Hits          6511     6909     +398     
- Misses         544      576      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lookatator Lookatator marked this pull request as ready for review April 27, 2023 10:36
@Lookatator Lookatator self-requested a review April 27, 2023 10:36
@Lookatator
Copy link
Member

Lookatator commented Nov 24, 2023

@felixchalumeau, do you have any comment regarding all the refactoring that has been done? 😄

Copy link
Collaborator Author

@felixchalumeau felixchalumeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with it!

@Lookatator Lookatator merged commit 82c0437 into develop Dec 11, 2023
5 checks passed
@Lookatator Lookatator deleted the feat/add-algo-aurora branch September 1, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants